Page MenuHomePhabricator

When "ArcanistRuntime" exits with a nonzero exit code, emit that exit code
ClosedPublic

Authored by epriestley on Feb 27 2020, 2:16 PM.
Tags
None
Referenced Files
F12847541: D21037.diff
Fri, Mar 29, 2:23 AM
Unknown Object (File)
Sat, Mar 23, 12:59 AM
Unknown Object (File)
Thu, Mar 14, 6:07 PM
Unknown Object (File)
Tue, Mar 5, 1:58 PM
Unknown Object (File)
Feb 15 2024, 1:32 PM
Unknown Object (File)
Dec 26 2023, 8:26 PM
Unknown Object (File)
Dec 23 2023, 2:53 PM
Unknown Object (File)
Dec 21 2023, 9:25 AM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/failed-arc-patch-does-not-return-non-zero-exit-code/3584.

Returning an integer from a top-level PHP file doesn't actually affect the process exit code, as much as I might wish it does.

Test Plan

Ran arc patch adflsnadfsln; echo $?, saw a nonzero exit code after this fix.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 27 2020, 2:17 PM
Harbormaster failed remote builds in B23928: Diff 50107!
This revision was not accepted when it landed; it landed in state Changes Planned.Feb 27 2020, 2:17 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.