Page MenuHomePhabricator
Differential D21037

When "ArcanistRuntime" exits with a nonzero exit code, emit that exit code
ClosedPublic
Actions

Authored by epriestley on Feb 27 2020, 2:16 PM.
Tags
None
Referenced Files
F14077360: D21037.diff
Thu, Nov 21, 10:55 PM
F14076741: D21037.diff
Thu, Nov 21, 7:31 PM
Unknown Object (File)
Mon, Nov 18, 3:14 AM
Unknown Object (File)
Thu, Nov 14, 2:54 PM
Unknown Object (File)
Sun, Nov 10, 2:32 AM
Unknown Object (File)
Tue, Nov 5, 6:54 PM
Unknown Object (File)
Sun, Oct 27, 2:46 AM
Unknown Object (File)
Oct 20 2024, 10:45 AM
View All Files
Subscribers
None

Details

Reviewers
None
Commits
rARC5451d2875221: When "ArcanistRuntime" exits with a nonzero exit code, emit that exit code
Summary

See https://discourse.phabricator-community.org/t/failed-arc-patch-does-not-return-non-zero-exit-code/3584.

Returning an integer from a top-level PHP file doesn't actually affect the process exit code, as much as I might wish it does.

Test Plan

Ran arc patch adflsnadfsln; echo $?, saw a nonzero exit code after this fix.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 27 2020, 2:16 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 27 2020, 2:17 PM
Harbormaster failed remote builds in B23928: Diff 50107!
This revision was not accepted when it landed; it landed in state Changes Planned.Feb 27 2020, 2:17 PM
This revision was landed with ongoing or failed builds.
Closed by commit rARC5451d2875221: When "ArcanistRuntime" exits with a nonzero exit code, emit that exit code (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARC5451d2875221: When "ArcanistRuntime" exits with a nonzero exit code, emit that exit code.

Revision Contents
Changeset List

PathSize
bin/
2 lines
2 lines
support/
init/
4 lines

Diff 50108

View Options

bin/arc

Loading...
View Options

bin/phage

Loading...
View Options

support/init/init-arcanist.php

Loading...
Phabricator · Built by Phacility