When "ArcanistRuntime" exits with a nonzero exit code, emit that exit code
ClosedPublic
Actions

Authored by epriestley on Feb 27 2020, 2:16 PM.

Details

Reviewers: None
Commits: rARC5451d2875221: When "ArcanistRuntime" exits with a nonzero exit code, emit that exit code

Summary

Returning an integer from a top-level PHP file doesn't actually affect the process exit code, as much as I might wish it does.

Test Plan

Ran arc patch adflsnadfsln; echo $?, saw a nonzero exit code after this fix.

Repository

rARC Arcanist

Branch

fx7

Lint

Lint Passed

Unit

No Test Coverage

Build Status

	Time	Test
	12 ms	ExecFutureTestCase::testResolveTimeoutTestShouldRunLessThan1Sec EXCEPTION (Exception): Future has already started; futures can not start more than once. #0 /core/data/drydock/workingcopy-83/repo/arcanist/src/future/FutureIterator.php(390): Future->startFuture() #1 /core/data/drydock/workingcopy-83/repo/arcanist/src/future/FutureIterator.php(366): FutureIterator->moveFutureToWork('Future/638')
	0 ms	AbstractDirectedGraphTestCase::testCyclicGraph 1 assertion(s) passed.
	0 ms	AbstractDirectedGraphTestCase::testEdgeLoadFailure 1 assertion(s) passed.
	0 ms	AbstractDirectedGraphTestCase::testNonTreeGraph 1 assertion(s) passed.
	0 ms	AbstractDirectedGraphTestCase::testNoncyclicGraph 1 assertion(s) passed.
		View Full Test Results (1 Failed · 463 Passed · 34 Skipped)