Page MenuHomePhabricator

When "ArcanistRuntime" exits with a nonzero exit code, emit that exit code
ClosedPublic

Authored by epriestley on Feb 27 2020, 2:16 PM.
Tags
None
Referenced Files
F13092155: D21037.diff
Thu, Apr 25, 3:27 AM
Unknown Object (File)
Wed, Apr 3, 7:40 AM
Unknown Object (File)
Fri, Mar 29, 2:23 AM
Unknown Object (File)
Mar 23 2024, 12:59 AM
Unknown Object (File)
Mar 14 2024, 6:07 PM
Unknown Object (File)
Mar 5 2024, 1:58 PM
Unknown Object (File)
Feb 15 2024, 1:32 PM
Unknown Object (File)
Dec 26 2023, 8:26 PM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/failed-arc-patch-does-not-return-non-zero-exit-code/3584.

Returning an integer from a top-level PHP file doesn't actually affect the process exit code, as much as I might wish it does.

Test Plan

Ran arc patch adflsnadfsln; echo $?, saw a nonzero exit code after this fix.

Diff Detail

Repository
rARC Arcanist
Branch
fx7
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23928
Build 32931: Run Core Tests
Build 32930: arc lint + arc unit

Unit TestsFailed

TimeTest
12 msExecFutureTestCase::testResolveTimeoutTestShouldRunLessThan1Sec
EXCEPTION (Exception): Future has already started; futures can not start more than once. #0 /core/data/drydock/workingcopy-83/repo/arcanist/src/future/FutureIterator.php(390): Future->startFuture() #1 /core/data/drydock/workingcopy-83/repo/arcanist/src/future/FutureIterator.php(366): FutureIterator->moveFutureToWork('Future/638')
0 msAbstractDirectedGraphTestCase::testCyclicGraph
1 assertion(s) passed.
0 msAbstractDirectedGraphTestCase::testEdgeLoadFailure
1 assertion(s) passed.
0 msAbstractDirectedGraphTestCase::testNonTreeGraph
1 assertion(s) passed.
0 msAbstractDirectedGraphTestCase::testNoncyclicGraph
1 assertion(s) passed.
View Full Test Results (1 Failed · 463 Passed · 34 Skipped)

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 27 2020, 2:17 PM
Harbormaster failed remote builds in B23928: Diff 50107!
This revision was not accepted when it landed; it landed in state Changes Planned.Feb 27 2020, 2:17 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.