Guard call to "get_magic_quotes_gpc()" with "@" to silence PHP 7.4+ warning
ClosedPublic
Actions

Authored by epriestley on Jan 14 2020, 8:21 PM.

Details

Reviewers: None
Maniphest Tasks: T13471: Guard call to "get_magic_quotes_gpc()" during startup
Commits: rP138ba8703147: Guard call to "get_magic_quotes_gpc()" with "@" to silence PHP 7.4+ warning

Summary

Fixes T13471. Recent versions of PHP raise a warning when this function is called.

We're only calling it so we can instantly fatal if it's enabled, so use "@" to silence the warning.

Test Plan

Loaded site; see also T13471 for a user reporting that this fix is effective.

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 14 2020, 8:22 PM

epriestley requested review of this revision.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			support/startup/PhabricatorStartup.php (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	49899	db6b4ca		Jan 14 2020, 8:21 PM	★	★
Diff 2	49900	db6b4ca	rP138ba87031475e04b134be47956fc077021437f0	Jan 14 2020, 8:22 PM	★	★