Differential D20942

Guard call to "get_magic_quotes_gpc()" with "@" to silence PHP 7.4+ warning
ClosedPublic
Actions

Authored by epriestley on Jan 14 2020, 8:21 PM.

Details

Reviewers: None
Maniphest Tasks: T13471: Guard call to "get_magic_quotes_gpc()" during startup
Commits: rP138ba8703147: Guard call to "get_magic_quotes_gpc()" with "@" to silence PHP 7.4+ warning

Summary

Fixes T13471. Recent versions of PHP raise a warning when this function is called.

We're only calling it so we can instantly fatal if it's enabled, so use "@" to silence the warning.

Test Plan

Loaded site; see also T13471 for a user reporting that this fix is effective.

Diff Detail

Repository

rP Phabricator

Branch

magic

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23725
Build 32623: Run Core Tests
Build 32622: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 14 2020, 8:21 PM

Harbormaster completed remote builds in B23725: Diff 49899.Jan 14 2020, 8:22 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 14 2020, 8:22 PM

epriestley requested review of this revision.

Closed by commit rP138ba8703147: Guard call to "get_magic_quotes_gpc()" with "@" to silence PHP 7.4+ warning (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP138ba8703147: Guard call to "get_magic_quotes_gpc()" with "@" to silence PHP 7.4+ warning.

epriestley mentioned this in D21549: Test if "get_magic_quotes_gpc()" exists before calling it.Feb 8 2021, 5:29 PM

epriestley mentioned this in rP67cf80b377bd: Test if "get_magic_quotes_gpc()" exists before calling it.Feb 8 2021, 5:34 PM

Revision Contents
Changeset List

Path

Size

support/

startup/

PhabricatorStartup.php

2 lines

Diff 49899

View Options

support/startup/PhabricatorStartup.php

Guard call to "get_magic_quotes_gpc()" with "@" to silence PHP 7.4+ warningClosedPublicActions