Differential D20890

Allow username changes which modify letter case to go through as valid
ClosedPublic
Actions

Authored by epriestley on Nov 6 2019, 4:08 PM.

Tags

None

Referenced Files

	F19477772: D20890.diff
	Wed, Jan 7, 8:43 PM

	F19468954: D20890.diff
	Sun, Jan 4, 1:10 PM

	F19232561: D20890.id49797.diff
	Sun, Dec 21, 5:14 PM

	F18828930: D20890.id.diff
	Oct 24 2025, 6:48 PM

	F18826034: D20890.diff
	Oct 24 2025, 2:09 AM

	F18810992: D20890.diff
	Oct 20 2025, 12:29 AM

	F18640779: D20890.id.diff
	Sep 18 2025, 6:51 PM

	F18589070: D20890.diff
	Sep 12 2025, 2:19 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13446: Allow username changes to change the letter case of an existing username
Commits: rPf5f2a0bc5696: Allow username changes which modify letter case to go through as valid

Summary

Fixes T13446. Currently, the validation logic here rejects a rename like "alice" to "ALICE" (which changes only letter case) but this is a permissible rename.

Allow collisions that collide with the same user to permit this rename.

Also, fix an issue where an empty rename was treated improperly.

Test Plan

Renamed "alice" to "ALICE".
- Before: username collision error.
- After: clean rename.
Renamed "alice" to "orange" (an existing user). Got an error.
Renamed "alice" to "", "!@#$", etc (invalid usernames). Got sensible errors.

Diff Detail

Repository

Branch

username1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23626
Build 32477: Run Core Tests
Build 32476: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 6 2019, 4:08 PM

Harbormaster completed remote builds in B23626: Diff 49796.Nov 6 2019, 4:10 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 6 2019, 4:10 PM

epriestley requested review of this revision.

Closed by commit rPf5f2a0bc5696: Allow username changes which modify letter case to go through as valid (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPf5f2a0bc5696: Allow username changes which modify letter case to go through as valid.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

xaction/

PhabricatorUserUsernameTransaction.php

21 lines

Diff 49796

src/applications/people/xaction/PhabricatorUserUsernameTransaction.php

Loading...