Page MenuHomePhabricator

Allow username changes which modify letter case to go through as valid
ClosedPublic

Authored by epriestley on Nov 6 2019, 4:08 PM.
Tags
None
Referenced Files
F12813659: D20890.id49796.diff
Thu, Mar 28, 1:19 AM
Unknown Object (File)
Tue, Mar 5, 7:10 AM
Unknown Object (File)
Wed, Feb 28, 2:07 AM
Unknown Object (File)
Feb 3 2024, 11:24 PM
Unknown Object (File)
Jan 4 2024, 9:22 AM
Unknown Object (File)
Dec 24 2023, 5:05 AM
Unknown Object (File)
Dec 23 2023, 11:24 PM
Unknown Object (File)
Dec 20 2023, 1:53 AM
Subscribers
None

Details

Summary

Fixes T13446. Currently, the validation logic here rejects a rename like "alice" to "ALICE" (which changes only letter case) but this is a permissible rename.

Allow collisions that collide with the same user to permit this rename.

Also, fix an issue where an empty rename was treated improperly.

Test Plan
  • Renamed "alice" to "ALICE".
    • Before: username collision error.
    • After: clean rename.
  • Renamed "alice" to "orange" (an existing user). Got an error.
  • Renamed "alice" to "", "!@#$", etc (invalid usernames). Got sensible errors.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Nov 6 2019, 4:10 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.