Differential D20890

Allow username changes which modify letter case to go through as valid
ClosedPublic
Actions

Authored by epriestley on Nov 6 2019, 4:08 PM.

Tags

None

Referenced Files

	F15470175: D20890.diff
	Fri, Apr 4, 8:57 PM

	F15459261: D20890.id.diff
	Mon, Mar 31, 11:28 AM

	F15424248: D20890.diff
	Sat, Mar 22, 9:07 PM

	F15424171: D20890.id49797.diff
	Sat, Mar 22, 8:39 PM

	F15422222: D20890.id.diff
	Sat, Mar 22, 6:45 AM

	F15422004: D20890.id49797.diff
	Sat, Mar 22, 4:27 AM

	F15411138: D20890.diff
	Wed, Mar 19, 8:51 AM

	F15411102: D20890.diff
	Wed, Mar 19, 8:50 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13446: Allow username changes to change the letter case of an existing username
Commits: rPf5f2a0bc5696: Allow username changes which modify letter case to go through as valid

Summary

Fixes T13446. Currently, the validation logic here rejects a rename like "alice" to "ALICE" (which changes only letter case) but this is a permissible rename.

Allow collisions that collide with the same user to permit this rename.

Also, fix an issue where an empty rename was treated improperly.

Test Plan

Renamed "alice" to "ALICE".
- Before: username collision error.
- After: clean rename.
Renamed "alice" to "orange" (an existing user). Got an error.
Renamed "alice" to "", "!@#$", etc (invalid usernames). Got sensible errors.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Nov 6 2019, 4:08 PM

Harbormaster completed remote builds in B23626: Diff 49796.Nov 6 2019, 4:10 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 6 2019, 4:10 PM

epriestley requested review of this revision.

Closed by commit rPf5f2a0bc5696: Allow username changes which modify letter case to go through as valid (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPf5f2a0bc5696: Allow username changes which modify letter case to go through as valid.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

xaction/

PhabricatorUserUsernameTransaction.php

21 lines

Diff 49797

src/applications/people/xaction/PhabricatorUserUsernameTransaction.php

Loading...