Page MenuHomePhabricator
Differential D20882

Remove "State Icons" from handles
ClosedPublic
Actions

Authored by epriestley on Oct 31 2019, 6:10 PM.

Details

Reviewers
None
Maniphest Tasks
T13440: Provide a richer "Revisions/Commits" UI in Maniphest
Commits
rPb0d9f89c9535: Remove "State Icons" from handles
Summary

Ref T13440. This feature is used in only one interface which I'm about to rewrite, so throw it away.

Test Plan

Grepped for all affected symbols, didn't find any hits anywhere.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Oct 31 2019, 6:10 PM
Harbormaster completed remote builds in B23610: Diff 49781.Oct 31 2019, 6:12 PM
epriestley requested review of this revision.Oct 31 2019, 6:12 PM
epriestley added a child revision: D20883: Show commits and revisions on tasks in a tabular view instead of handle lists.Oct 31 2019, 6:13 PM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 31 2019, 7:04 PM
Closed by commit rPb0d9f89c9535: Remove "State Icons" from handles (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPb0d9f89c9535: Remove "State Icons" from handles.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
phid/
9 lines
maniphest/
controller/
6 lines
phid/
53 lines
view/
15 lines
15 lines
repository/
phid/
10 lines

Diff 49784

View Options

src/applications/differential/phid/DifferentialRevisionPHIDType.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...
View Options

src/applications/phid/PhabricatorObjectHandle.php

Loading...
View Options

src/applications/phid/view/PHUIHandleListView.php

Loading...
View Options

src/applications/phid/view/PHUIHandleView.php

Loading...
View Options

src/applications/repository/phid/PhabricatorRepositoryCommitPHIDType.php

Loading...
Phabricator · Built by Phacility