Differential D20884

Add support for rendering section dividers in tables; use section dividers for changes on tasks
ClosedPublic
Actions

Authored by epriestley on Thu, Oct 31, 7:01 PM.

Details

Reviewers: None
Maniphest Tasks: T13440: Provide a richer "Revisions/Commits" UI in Maniphest
Commits: rPc48f300eb169: Add support for rendering section dividers in tables; use section dividers for…

Summary

Depends on D20883. Ref T13440. In most cases, all changes belong to the same repository, which makes the "Repository" column redundant and visually noisy. Show repository information in a section header.

Test Plan

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Oct 31, 7:01 PM

Harbormaster completed remote builds in B23612: Diff 49783.Thu, Oct 31, 7:03 PM

epriestley requested review of this revision.Thu, Oct 31, 7:03 PM

This revision was not accepted when it landed; it landed in state Needs Review.Thu, Oct 31, 7:13 PM

Closed by commit rPc48f300eb169: Add support for rendering section dividers in tables; use section dividers for… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPc48f300eb169: Add support for rendering section dividers in tables; use section dividers for….

Revision Contents
Changeset List

			Path	Packages
M			resources/celerity/map.php (6 lines)
M			src/applications/maniphest/controller/ManiphestTaskDetailController.php (52 lines)
M			src/view/control/AphrontTableView.php (27 lines)
M			webroot/rsrc/css/aphront/table-view.css (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	49783	6d8d054		Thu, Oct 31, 7:01 PM	★	★
Diff 2	49786	7bdfe5b	rPc48f300eb16954ef7f254be55f8a3df777061422	Thu, Oct 31, 7:13 PM	★	★

Status	Author	Revision
Closed	epriestley	D20884 Add support for rendering section dividers in tables; use section dividers for changes on tasks
Closed	epriestley	D20883 Show commits and revisions on tasks in a tabular view instead of handle lists
Closed	epriestley	D20882 Remove "State Icons" from handles