Page MenuHomePhabricator

Improve project member list behaviors related to disabled users
ClosedPublic

Authored by epriestley on Oct 25 2019, 1:35 AM.

Details

Summary

Fixes T13431.

Increase the "panel" version of project member lists to 10 users, hide disabled users, swap the buttons to "tail buttons".

Sort disabled users to the bottom of "full list" versions of member lists.

For UI consistency, render the remove "X" as disabled but visible if users don't have permission to remove members.

Test Plan
  • Viewed a project with disabled members.
    • Saw only enabled members on the main project page.
    • Saw disabled members sorted to the bottom on the members page.
  • Clicked "View All" to jump from the panel to the members page.
  • As a user who could not edit a project, viewed the members page and saw a disabled "X" with a policy error when clicked.
    • Removed a member as before, as a normal user with permission to remove members.

Diff Detail

Repository
rP Phabricator
Branch
disable1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23564
Build 32386: Run Core Tests
Build 32385: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Oct 25 2019, 1:41 AM
This revision was automatically updated to reflect the committed changes.