Differential D20857

Add a lint check for deprecated argument order to "implode()"
ClosedPublic
Actions

Authored by epriestley on Oct 17 2019, 4:05 PM.

Details

Reviewers: None
Maniphest Tasks: T13428: PHP 7.4 now warns about "implode()" argument order
Commits: rARC79ec6e44594f: (stable) Promote 2019 Week 43
rARCda6d4f85eefb: Add a lint check for deprecated argument order to "implode()"

Summary

Ref T13428. Historically, "implode()" accepts arguments in either order. PHP 7.4+ warns about glue not being first.

Add a lint check when the second parameter is a static scalar, implying it is the glue parameter.

Test Plan

Ran unit tests. See next change.

Diff Detail

Repository

rARC Arcanist

Branch

implode1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23552
Build 32367: Run Core Tests
Build 32366: arc lint + arc unit

Event Timeline

epriestley created this revision.Oct 17 2019, 4:05 PM

Harbormaster completed remote builds in B23552: Diff 49724.Oct 17 2019, 4:06 PM

epriestley requested review of this revision.Oct 17 2019, 4:06 PM

epriestley mentioned this in D20858: Fix deprecated argument order for "implode()".Oct 17 2019, 4:07 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 17 2019, 4:09 PM

Closed by commit rARCda6d4f85eefb: Add a lint check for deprecated argument order to "implode()" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCda6d4f85eefb: Add a lint check for deprecated argument order to "implode()".

epriestley mentioned this in rP5dafabd5b4d0: Fix deprecated argument order for "implode()".Oct 17 2019, 4:11 PM

epriestley added a commit: rARC79ec6e44594f: (stable) Promote 2019 Week 43.Oct 26 2019, 3:34 PM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

lint/

linter/

xhpast/

rules/

ArcanistImplodeArgumentOrderXHPASTLinterRule.php

39 lines

__tests__/

ArcanistImplodeArgumentOrderXHPASTLinterRuleTestCase.php

11 lines

implode-argument-order/

implode.lint-test

18 lines

Diff 49724

View Options

src/__phutil_library_map__.php

View Options

src/lint/linter/xhpast/rules/ArcanistImplodeArgumentOrderXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/tests/ArcanistImplodeArgumentOrderXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/tests/implode-argument-order/implode.lint-test

Add a lint check for deprecated argument order to "implode()"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49724

src/__phutil_library_map__.php

src/lint/linter/xhpast/rules/ArcanistImplodeArgumentOrderXHPASTLinterRule.php

src/lint/linter/xhpast/rules/__tests__/ArcanistImplodeArgumentOrderXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/implode-argument-order/implode.lint-test

Add a lint check for deprecated argument order to "implode()"
ClosedPublic
Actions

Revision Contents
Changeset List

src/lint/linter/xhpast/rules/tests/ArcanistImplodeArgumentOrderXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/implode-argument-order/implode.lint-test