Differential D20816

Track chart datapoints from their sources and provide a tabular view of chart data
ClosedPublic
Actions

Authored by epriestley on Sep 16 2019, 10:34 PM.

Details

Reviewers: None
Maniphest Tasks: T13279: Build Charting for Facts
Commits: rP080e132aa740: Track chart datapoints from their sources and provide a tabular view of chart…

Summary

Depends on D20815. Ref T13279. Give datapoints "refs", which allow us to figure out where particular datapoints came from even after the point is transformed by functions. For now, show the raw points in a table below the chart.

Test Plan

Viewed chart data, saw reasonable-looking numbers.

Diff Detail

Repository

rP Phabricator

Branch

chart3

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/fact/chart/PhabricatorComposeChartFunction.php:74	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 23455
Build 32228: Run Core Tests
Build 32227: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 16 2019, 10:34 PM

Herald added a subscriber: yelirekim. · View Herald TranscriptSep 16 2019, 10:34 PM

Harbormaster completed remote builds in B23455: Diff 49629.Sep 16 2019, 10:36 PM

epriestley requested review of this revision.Sep 16 2019, 10:36 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 17 2019, 4:41 PM

Closed by commit rP080e132aa740: Track chart datapoints from their sources and provide a tabular view of chart… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP080e132aa740: Track chart datapoints from their sources and provide a tabular view of chart….

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

fact/

chart/

PhabricatorAccumulateChartFunction.php

10 lines

PhabricatorChartDataset.php

31 lines

PhabricatorChartFunction.php

2 lines

PhabricatorComposeChartFunction.php

18 lines

PhabricatorFactChartFunction.php

68 lines

PhabricatorHigherOrderChartFunction.php

34 lines

PhabricatorPureChartFunction.php

12 lines

controller/

PhabricatorFactChartController.php

12 lines

engine/

PhabricatorChartRenderingEngine.php

142 lines

Diff 49629

View Options

src/__phutil_library_map__.php

View Options

src/applications/fact/chart/PhabricatorAccumulateChartFunction.php

View Options

src/applications/fact/chart/PhabricatorChartDataset.php

View Options

src/applications/fact/chart/PhabricatorChartFunction.php

View Options

src/applications/fact/chart/PhabricatorComposeChartFunction.php

View Options

src/applications/fact/chart/PhabricatorFactChartFunction.php

View Options

src/applications/fact/chart/PhabricatorHigherOrderChartFunction.php

View Options

src/applications/fact/chart/PhabricatorPureChartFunction.php

View Options

src/applications/fact/controller/PhabricatorFactChartController.php

View Options

src/applications/fact/engine/PhabricatorChartRenderingEngine.php

Track chart datapoints from their sources and provide a tabular view of chart dataClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49629

src/__phutil_library_map__.php

src/applications/fact/chart/PhabricatorAccumulateChartFunction.php

src/applications/fact/chart/PhabricatorChartDataset.php

src/applications/fact/chart/PhabricatorChartFunction.php

src/applications/fact/chart/PhabricatorComposeChartFunction.php

src/applications/fact/chart/PhabricatorFactChartFunction.php

src/applications/fact/chart/PhabricatorHigherOrderChartFunction.php

src/applications/fact/chart/PhabricatorPureChartFunction.php

src/applications/fact/controller/PhabricatorFactChartController.php

src/applications/fact/engine/PhabricatorChartRenderingEngine.php

Track chart datapoints from their sources and provide a tabular view of chart data
ClosedPublic
Actions

Revision Contents
Changeset List