Differential D20814

In stacked area charts, group nearby points so they don't overlap
ClosedPublic
Actions

Authored by epriestley on Sep 16 2019, 5:41 PM.

Details

Reviewers: None
Maniphest Tasks: T13279: Build Charting for Facts
Commits: rPf529abf90065: In stacked area charts, group nearby points so they don't overlap

Summary

Ref T13279. We currently draw a point on the chart for each datapoint, but this leads to many overlapping circles. Instead, aggregate the raw points into display points ("events") at the end.

Test Plan

Viewed a stacked area chart with many points, saw a more palatable number of drawn dots.

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sep 16 2019, 5:41 PM

Herald added a subscriber: yelirekim. · View Herald TranscriptSep 16 2019, 5:41 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 16 2019, 5:41 PM

Harbormaster failed remote builds in Unknown Object (Buildable)!

epriestley mentioned this in T13279: Build Charting for Facts.Sep 16 2019, 5:44 PM

epriestley added a child revision: D20815: In charts, make "min" and "max" into pure functions and formally mark pure functions as pure.Sep 16 2019, 6:41 PM

Fix library map issue.

Harbormaster completed remote builds in B23453: Diff 49627.Sep 16 2019, 6:47 PM

epriestley requested review of this revision.Sep 16 2019, 6:47 PM

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Sep 17, 4:27 PM

Closed by commit rPf529abf90065: In stacked area charts, group nearby points so they don't overlap (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPf529abf90065: In stacked area charts, group nearby points so they don't overlap.

Revision Contents
Changeset List

			Path	Packages
M			resources/celerity/map.php (20 lines)
M			src/applications/fact/chart/PhabricatorChartStackedAreaDataset.php (61 lines)
M			webroot/rsrc/css/phui/phui-chart.css (7 lines)
M			webroot/rsrc/js/application/fact/Chart.js (22 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	49627	3dcb4a7	- Fix library map issue.	Sep 16 2019, 6:45 PM	★	★
Diff 2	49631	c5a4dea	rPf529abf90065888f9139e4b2b123fd1dfd00c01b	Tue, Sep 17, 4:26 PM	★	★

Status	Author	Revision
Closed	epriestley	D20816 Track chart datapoints from their sources and provide a tabular view of chart data
Closed	epriestley	D20815 In charts, make "min" and "max" into pure functions and formally mark pure functions as pure
Closed	epriestley	D20814 In stacked area charts, group nearby points so they don't overlap