Page MenuHomePhabricator

Use the "@" operator to silence connection retry messages if initializing the stack with database config optional
ClosedPublic

Authored by epriestley on Sep 3 2019, 7:26 PM.

Details

Summary

Depends on D20780. Ref T13403. During initial setup, it's routine to run "bin/config" with a bad database config. We start the stack in "config optional" mode to anticipate this.

However, even in this mode, we may emit warnings if the connection fails in certain ways. These warnings aren't useful; suppress them with "@".

(Possibly this message should move from "phlog()" to "--trace" at some point, but it has a certain amount of context/history around it.)

Test Plan
  • Configured MySQL to fail with a retryable error, e.g. good host but bad port.
  • Ran bin/config set ....
  • Before: saw retry warnings on stderr.
  • After: no retry warnings on stderr.
  • (Turned off suppression code artificially and verified warnings still appear under normal startup.)

Diff Detail

Repository
rP Phabricator
Branch
config3
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 23374
Build 32110: Run Core Tests
Build 32109: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 3 2019, 7:54 PM
This revision was automatically updated to reflect the committed changes.