Page MenuHomePhabricator
Differential D20712

When many commits are discovered at once, import them at lower priority
ClosedPublic
Actions

Authored by epriestley on Aug 12 2019, 7:09 PM.

Details

Reviewers
None
Maniphest Tasks
T13369: When a large number of commits are pushed to a repository, import them at lower priority
Commits
rP82cf97ad65a9: When many commits are discovered at once, import them at lower priority
Summary

Ref T13369. See that task for discussion.

When the discovery daemon finds more than 64 commits to import, demote the worker queue priority of the resulting tasks.

Test Plan
  • Pushed one commit, ran bin/repository discover --verbose --trace ..., saw commit import with "at normal priority" message and priority 2500 ("PRIORITY_COMMIT").
  • Pushed 3 commits, set threshold to 3, ran bin/repository discover ..., saw commist import with "at lower priority" message and priority 4000 ("PRIORITY_IMPORT").

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Aug 12 2019, 7:09 PM
Harbormaster completed remote builds in B23249: Diff 49389.Aug 12 2019, 7:11 PM
epriestley requested review of this revision.Aug 12 2019, 7:11 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2019, 7:59 PM
Closed by commit rP82cf97ad65a9: When many commits are discovered at once, import them at lower priority (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP82cf97ad65a9: When many commits are discovered at once, import them at lower priority.

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
engine/
106 lines
storage/
2 lines

Diff 49392

View Options

src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
Phabricator · Built by Phacility