Paths

Table of Contentst

Differential D20712

When many commits are discovered at once, import them at lower priority
ClosedPublic
Actions

Authored by epriestley on Aug 12 2019, 7:09 PM.

Tags

None

Referenced Files

	F13099034: D20712.diff
	Fri, Apr 26, 12:23 PM

	Unknown Object (File)
	Thu, Apr 25, 1:40 AM

	Unknown Object (File)
	Sat, Apr 20, 4:53 PM

	Unknown Object (File)
	Thu, Apr 11, 9:29 AM

	Unknown Object (File)
	Sun, Mar 31, 11:00 PM

	Unknown Object (File)
	Mar 24 2024, 7:52 AM

	Unknown Object (File)
	Mar 4 2024, 10:49 PM

	Unknown Object (File)
	Feb 12 2024, 8:27 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13369: When a large number of commits are pushed to a repository, import them at lower priority
Commits: rP82cf97ad65a9: When many commits are discovered at once, import them at lower priority

Summary

Ref T13369. See that task for discussion.

When the discovery daemon finds more than 64 commits to import, demote the worker queue priority of the resulting tasks.

Test Plan

Pushed one commit, ran bin/repository discover --verbose --trace ..., saw commit import with "at normal priority" message and priority 2500 ("PRIORITY_COMMIT").
Pushed 3 commits, set threshold to 3, ran bin/repository discover ..., saw commist import with "at lower priority" message and priority 4000 ("PRIORITY_IMPORT").

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Aug 12 2019, 7:09 PM

Harbormaster completed remote builds in B23249: Diff 49389.Aug 12 2019, 7:11 PM

epriestley requested review of this revision.Aug 12 2019, 7:11 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2019, 7:59 PM

Closed by commit rP82cf97ad65a9: When many commits are discovered at once, import them at lower priority (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP82cf97ad65a9: When many commits are discovered at once, import them at lower priority.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

engine/

PhabricatorRepositoryDiscoveryEngine.php

106 lines

storage/

PhabricatorRepository.php

2 lines

Diff 49392

src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php

Loading...

src/applications/repository/storage/PhabricatorRepository.php

Loading...