Page MenuHomePhabricator

When many commits are discovered at once, import them at lower priority
ClosedPublic

Authored by epriestley on Aug 12 2019, 7:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 8:48 PM
Unknown Object (File)
Sun, Nov 3, 1:16 PM
Unknown Object (File)
Oct 22 2024, 3:19 AM
Unknown Object (File)
Oct 18 2024, 12:19 AM
Unknown Object (File)
Oct 11 2024, 10:17 AM
Unknown Object (File)
Oct 3 2024, 12:15 AM
Unknown Object (File)
Sep 6 2024, 6:37 AM
Unknown Object (File)
Sep 4 2024, 7:41 AM
Subscribers
None

Details

Summary

Ref T13369. See that task for discussion.

When the discovery daemon finds more than 64 commits to import, demote the worker queue priority of the resulting tasks.

Test Plan
  • Pushed one commit, ran bin/repository discover --verbose --trace ..., saw commit import with "at normal priority" message and priority 2500 ("PRIORITY_COMMIT").
  • Pushed 3 commits, set threshold to 3, ran bin/repository discover ..., saw commist import with "at lower priority" message and priority 4000 ("PRIORITY_IMPORT").

Diff Detail

Repository
rP Phabricator
Branch
lopri1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23249
Build 31937: Run Core Tests
Build 31936: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2019, 7:59 PM
This revision was automatically updated to reflect the committed changes.