Page MenuHomePhabricator
Differential D20602

Deprecate "bin/phd ... --gently" and update documentation
ClosedPublic
Actions

Authored by epriestley on Jun 20 2019, 9:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 21, 4:14 PM
Unknown Object (File)
Sat, Apr 20, 4:51 PM
Unknown Object (File)
Fri, Apr 19, 9:21 AM
Unknown Object (File)
Wed, Apr 17, 3:17 PM
Unknown Object (File)
Thu, Apr 11, 7:25 AM
Unknown Object (File)
Sun, Mar 31, 5:36 PM
Unknown Object (File)
Sat, Mar 30, 8:12 AM
Unknown Object (File)
Wed, Mar 27, 9:34 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date
Commits
rPb99c240aa374: Deprecate "bin/phd ... --gently" and update documentation
Summary

Ref T13321. Previously, the behavior was:

  • bin/phd stop --gently: Stop all daemons with PID files that belong to the current instance.
  • bin/phd stop: Stop all daemons with PID files that belong to the current instance. Complain if there are more processes.
  • bin/phd stop --force: Stop all processes that look like daemons, ignoring instances.

The new behavior is:

  • bin/phd stop: Stop all processes that look like daemons and belong to the current instance.
  • bin/phd stop --force: Stop all processes that look like daemons, period.
Test Plan

Grep / documentation only.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 20 2019, 9:23 PM
epriestley added a comment.Jun 20 2019, 9:23 PM

(I'm deprecating (rather than removing) --gently because some deploy stuff in core/ uses it.)

Harbormaster completed remote builds in B23009: Diff 49137.Jun 20 2019, 9:24 PM
epriestley requested review of this revision.Jun 20 2019, 9:24 PM
amckinley accepted this revision.Jun 20 2019, 10:34 PM
This revision is now accepted and ready to land.Jun 20 2019, 10:34 PM
Closed by commit rPb99c240aa374: Deprecate "bin/phd ... --gently" and update documentation (authored by epriestley). · Explain WhyJun 24 2019, 6:16 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPb99c240aa374: Deprecate "bin/phd ... --gently" and update documentation.

Revision Contents
Changeset List

Diff 49168

View Options

src/applications/daemon/management/PhabricatorDaemonManagementRestartWorkflow.php

Loading...
View Options

src/applications/daemon/management/PhabricatorDaemonManagementStopWorkflow.php

Loading...
Phabricator · Built by Phacility