Page MenuHomePhabricator

Deprecate "bin/phd ... --gently" and update documentation
ClosedPublic

Authored by epriestley on Jun 20 2019, 9:23 PM.

Details

Summary

Ref T13321. Previously, the behavior was:

  • bin/phd stop --gently: Stop all daemons with PID files that belong to the current instance.
  • bin/phd stop: Stop all daemons with PID files that belong to the current instance. Complain if there are more processes.
  • bin/phd stop --force: Stop all processes that look like daemons, ignoring instances.

The new behavior is:

  • bin/phd stop: Stop all processes that look like daemons and belong to the current instance.
  • bin/phd stop --force: Stop all processes that look like daemons, period.
Test Plan

Grep / documentation only.

Diff Detail

Repository
rP Phabricator
Branch
pquery3
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 23009
Build 31587: Run Core Tests
Build 31586: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 20 2019, 9:23 PM

(I'm deprecating (rather than removing) --gently because some deploy stuff in core/ uses it.)

epriestley requested review of this revision.Jun 20 2019, 9:24 PM
amckinley accepted this revision.Jun 20 2019, 10:34 PM
This revision is now accepted and ready to land.Jun 20 2019, 10:34 PM