Differential D20585

Fix another stray "msort()/msortv()" issue
ClosedPublic
Actions

Authored by epriestley on Jun 17 2019, 8:11 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes

Commits

rP2bc045bab8d7: Fix another stray "msort()/msortv()" issue

Summary

Ref T13303. See B22967. This should be "msortv()" but didn't get updated properly.

Test Plan

The system works!

Diff Detail

Repository

rP Phabricator

Branch

msortv2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22968
Build 31523: Run Core Tests
Build 31522: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 17 2019, 8:11 PM

epriestley mentioned this in rP874282db7589: Correct "msort()" vs "msortv()" to more fully stabilize transaction sorts after….Jun 17 2019, 8:12 PM

Harbormaster completed remote builds in B22968: Diff 49093.Jun 17 2019, 8:13 PM

epriestley requested review of this revision.Jun 17 2019, 8:13 PM

amckinley accepted this revision.Jun 17 2019, 8:19 PM

This revision is now accepted and ready to land.Jun 17 2019, 8:19 PM

Closed by commit rP2bc045bab8d7: Fix another stray "msort()/msortv()" issue (authored by epriestley). · Explain WhyJun 17 2019, 8:20 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP2bc045bab8d7: Fix another stray "msort()/msortv()" issue.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

command/

DifferentialActionEmailCommand.php

2 lines

Diff 49093

View Options

src/applications/differential/command/DifferentialActionEmailCommand.php

Fix another stray "msort()/msortv()" issueClosedPublicActions