Differential D20573

When a user clicks a navigation link in a dialog, close the dialog
ClosedPublic
Actions

Authored by epriestley on Jun 6 2019, 1:50 AM.

Tags

None

Referenced Files

	F16688558: D20573.id49115.diff
	Tue, Jun 17, 3:23 PM

	F16548501: D20573.id49076.diff
	Tue, Jun 17, 1:02 AM

	F16528773: D20573.diff
	Mon, Jun 16, 10:43 PM

	Unknown Object (File)
	Sun, Jun 15, 8:42 PM

	Unknown Object (File)
	Sat, Jun 14, 2:51 AM

	Unknown Object (File)
	Sat, Jun 14, 2:51 AM

	Unknown Object (File)
	Wed, May 21, 8:10 PM

	Unknown Object (File)
	May 7 2025, 6:26 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it

Commits

rPdcf3ca8e0450: When a user clicks a navigation link in a dialog, close the dialog

Summary

Ref T13302. Currently, if you enable Quicksand (by clicking "Persistent Chat"), open a dialog with links in it (like "Create Subtask" with multiple available subtypes), and then follow a navigation link, the page content reloads behind the dialog but the dialog stays in the foreground.

Fix this by closing dialogs when users click navigation links inside them.

Test Plan

With Quicksand enabled and disabled, clicked a subtask type in the "Create Subtask" dialog.

Before, Quicksand Disabled: Dialog stays on screen, then navigation occurs.
After, Quicksand Disabled: Dialog vanishes, then navigation occurs.
Before, Quicksand Enabled: Dialog stays on screen, navigation occurs behind it.
After, Quicksand Enabled: Dialog vanishes, then navigation occurs.

Diff Detail

Repository

Branch

quicksand1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22951
Build 31495: Run Core Tests
Build 31494: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 6 2019, 1:50 AM

Harbormaster completed remote builds in B22951: Diff 49076.Jun 6 2019, 1:52 AM

epriestley requested review of this revision.Jun 6 2019, 1:52 AM

epriestley mentioned this in T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it.Jun 6 2019, 1:56 AM

amckinley accepted this revision.Jun 18 2019, 9:49 PM

amckinley added inline comments.

webroot/rsrc/externals/javelin/lib/Workflow.js
98	Needs less "so", I think.

This revision is now accepted and ready to land.Jun 18 2019, 9:49 PM

Make it less so.

Harbormaster completed remote builds in B22987: Diff 49113.Jun 18 2019, 10:13 PM

Closed by commit rPdcf3ca8e0450: When a user clicks a navigation link in a dialog, close the dialog (authored by epriestley). · Explain WhyJun 18 2019, 10:16 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPdcf3ca8e0450: When a user clicks a navigation link in a dialog, close the dialog.

epriestley mentioned this in D20590: Use "link.getAttribute('href')", not "link.href", to bypass dark browser magic.Jun 19 2019, 5:24 PM

epriestley mentioned this in rP9f44ee393343: Use "link.getAttribute('href')", not "link.href", to bypass dark browser magic.Jun 19 2019, 5:44 PM

epriestley mentioned this in T13363: In "Edit Subtasks" dialog, clicking a task tile sometimes (?) closes the dialog.Aug 1 2019, 6:59 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

webroot/

rsrc/

externals/

javelin/

lib/

48 lines

Diff 49076

resources/celerity/map.php

Loading...

webroot/rsrc/externals/javelin/lib/Workflow.js

Loading...