Page MenuHomePhabricator

Render timezone names more readably, with spaces rather than underscores ("America/Los Angeles", not "America/Los_Angeles").
ClosedPublic

Authored by epriestley on May 30 2019, 3:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 3, 9:49 PM
Unknown Object (File)
Mon, Apr 1, 6:43 AM
Unknown Object (File)
Sat, Mar 23, 7:21 AM
Unknown Object (File)
Sat, Mar 23, 7:21 AM
Unknown Object (File)
Dec 23 2023, 10:54 AM
Unknown Object (File)
Dec 22 2023, 5:21 AM
Unknown Object (File)
Dec 20 2023, 6:37 PM
Unknown Object (File)
Dec 19 2023, 12:40 PM
Subscribers
None

Details

Summary

See downstream https://phabricator.wikimedia.org/T902. Currently, timezones are rendered with their raw internal names (like America/Los_Angeles) which include underscores.

Replacing underscores with spaces is a more human-readable (and perhaps meaningfully better for things like screen readers, although this is pure speculation).

There's some vague argument against this, like "administrators may need to set a raw internal value in phabricator.timezone and this could mislead them", but we already give a pretty good error message if you do this and could improve hinting if necessary.

Test Plan

Viewed timezone list in Settings and the timezone "reconcile" dialog, saw a more-readable "Los Angeles".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable