Page MenuHomePhabricator

Render timezone names more readably, with spaces rather than underscores ("America/Los Angeles", not "America/Los_Angeles").
ClosedPublic

Authored by epriestley on May 30 2019, 3:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 7:49 AM
Unknown Object (File)
Sun, Feb 9, 7:49 AM
Unknown Object (File)
Sun, Feb 9, 7:49 AM
Unknown Object (File)
Sun, Feb 9, 7:49 AM
Unknown Object (File)
Wed, Jan 29, 6:16 AM
Unknown Object (File)
Wed, Jan 29, 1:58 AM
Unknown Object (File)
Tue, Jan 28, 7:31 AM
Unknown Object (File)
Mon, Jan 27, 10:56 PM
Subscribers
None

Details

Summary

See downstream https://phabricator.wikimedia.org/T902. Currently, timezones are rendered with their raw internal names (like America/Los_Angeles) which include underscores.

Replacing underscores with spaces is a more human-readable (and perhaps meaningfully better for things like screen readers, although this is pure speculation).

There's some vague argument against this, like "administrators may need to set a raw internal value in phabricator.timezone and this could mislead them", but we already give a pretty good error message if you do this and could improve hinting if necessary.

Test Plan

Viewed timezone list in Settings and the timezone "reconcile" dialog, saw a more-readable "Los Angeles".

Diff Detail

Repository
rP Phabricator
Branch
tz1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22920
Build 31444: Run Core Tests
Build 31443: arc lint + arc unit