Page MenuHomePhabricator

Render timezone names more readably, with spaces rather than underscores ("America/Los Angeles", not "America/Los_Angeles").
ClosedPublic

Authored by epriestley on May 30 2019, 3:07 PM.
Tags
None
Referenced Files
F18985115: D20559.id49045.diff
Mon, Nov 17, 12:53 PM
F18984270: D20559.diff
Mon, Nov 17, 10:52 AM
F18816000: D20559.id.diff
Tue, Oct 21, 4:34 AM
F18806761: D20559.id49049.diff
Sat, Oct 18, 9:27 PM
F18744913: D20559.diff
Oct 3 2025, 4:37 AM
F18733973: D20559.id.diff
Sep 30 2025, 10:45 PM
F18629755: D20559.id49045.diff
Sep 16 2025, 9:48 AM
F18570288: D20559.id49049.diff
Sep 10 2025, 3:20 AM
Subscribers
None

Details

Summary

See downstream https://phabricator.wikimedia.org/T902. Currently, timezones are rendered with their raw internal names (like America/Los_Angeles) which include underscores.

Replacing underscores with spaces is a more human-readable (and perhaps meaningfully better for things like screen readers, although this is pure speculation).

There's some vague argument against this, like "administrators may need to set a raw internal value in phabricator.timezone and this could mislead them", but we already give a pretty good error message if you do this and could improve hinting if necessary.

Test Plan

Viewed timezone list in Settings and the timezone "reconcile" dialog, saw a more-readable "Los Angeles".

Diff Detail

Repository
rP Phabricator
Branch
tz1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22920
Build 31444: Run Core Tests
Build 31443: arc lint + arc unit