Page MenuHomePhabricator

Remove misleading reference to "search_documentfield" in documentation
Changes PlannedPublic

Authored by epriestley on May 23 2019, 5:00 PM.

Details

Summary

Depends on D20549. Ref T11741. I removed this table in D20549, but both versions are slightly misleading because we actually use two MyISAM tables: "search_docmentfield" and "conpherence_index".

I just separated this out and would plan to land it after "conpherence_index" is removed so there are zero misleading lies at that point.

Test Plan

Grep / reading.

Diff Detail

Repository
rP Phabricator
Branch
myisam2
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 22899
Build 31412: Run Core Tests
Build 31411: arc lint + arc unit

Event Timeline

epriestley created this revision.May 23 2019, 5:00 PM
epriestley requested review of this revision.May 23 2019, 5:01 PM

This looks good, except as you said, we can't land it until after we remove conpherence_index as well. Should I just approve it now and let it hang around in your unlanded revisions?

epriestley planned changes to this revision.May 23 2019, 5:57 PM

I'll just hold on to it for now in case something weird comes up, not a big deal if this doesn't land at the earliest possible moment.