Page MenuHomePhabricator

Remove misleading reference to "search_documentfield" in documentation
Changes PlannedPublic

Authored by epriestley on May 23 2019, 5:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 3:23 PM
Unknown Object (File)
Feb 27 2024, 7:03 AM
Unknown Object (File)
Feb 12 2024, 11:22 PM
Unknown Object (File)
Feb 3 2024, 10:35 PM
Unknown Object (File)
Jan 25 2024, 10:46 AM
Unknown Object (File)
Jan 16 2024, 8:25 AM
Unknown Object (File)
Dec 26 2023, 8:21 PM
Unknown Object (File)
Dec 23 2023, 9:05 PM
Subscribers
None

Details

Summary

Depends on D20549. Ref T11741. I removed this table in D20549, but both versions are slightly misleading because we actually use two MyISAM tables: "search_docmentfield" and "conpherence_index".

I just separated this out and would plan to land it after "conpherence_index" is removed so there are zero misleading lies at that point.

Test Plan

Grep / reading.

Diff Detail

Repository
rP Phabricator
Branch
myisam2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22899
Build 31412: Run Core Tests
Build 31411: arc lint + arc unit

Event Timeline

This looks good, except as you said, we can't land it until after we remove conpherence_index as well. Should I just approve it now and let it hang around in your unlanded revisions?

I'll just hold on to it for now in case something weird comes up, not a big deal if this doesn't land at the earliest possible moment.