Page MenuHomePhabricator

In the Herald test console, don't consider transactions that Herald rules applied
ClosedPublic

Authored by epriestley on May 22 2019, 9:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 7:20 AM
Unknown Object (File)
Sat, Mar 23, 7:19 AM
Unknown Object (File)
Sun, Mar 10, 12:14 AM
Unknown Object (File)
Feb 7 2024, 5:20 AM
Unknown Object (File)
Jan 31 2024, 11:22 AM
Unknown Object (File)
Jan 11 2024, 12:09 PM
Unknown Object (File)
Jan 5 2024, 1:29 PM
Unknown Object (File)
Dec 24 2023, 11:30 PM
Subscribers
None

Details

Summary

Depends on D20546. Ref T13283. Currently, if you do something (transactions "A", "B") and Herald does some things in response (transaction "C"), Herald acts only on the things you did ("A", "B") since the thing it did ("C") didn't exist yet, until it ran.

However, if you use the test console to test rules against the object we'll pick up all three transactions since they're all part of the same group. This isn't ideal.

To fix this, skip transactions which Herald applied, since it obviously didn't consider them when it was evaluating.

Test Plan
  • Created a revision, in the presence of a Herald rule that adds reviewers.
  • Then, ran the revision through the test console.
  • Before: saw the "Herald added reviewers: ..." transaction in the transaction group Herald evaluated.
  • After: saw only authentic human transactions.

Screen Shot 2019-05-22 at 2.44.45 PM.png (340×1 px, 69 KB)

Diff Detail

Repository
rP Phabricator
Branch
xgroup2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22886
Build 31396: Run Core Tests
Build 31395: arc lint + arc unit