Page MenuHomePhabricator

Use the same transaction group ID for transactions applied indirectly by a sub-editor
ClosedPublic

Authored by epriestley on May 22 2019, 9:41 PM.
Tags
None
Referenced Files
F15473967: D20546.diff
Sun, Apr 6, 3:35 AM
F15470993: D20546.id.diff
Sat, Apr 5, 2:50 AM
F15469430: D20546.diff
Fri, Apr 4, 1:05 PM
F15457692: D20546.diff
Sun, Mar 30, 5:49 PM
F15444721: D20546.id.diff
Thu, Mar 27, 10:53 AM
F15424522: D20546.diff
Sat, Mar 22, 10:52 PM
F15416312: D20546.id49020.diff
Thu, Mar 20, 10:29 AM
F15302380: D20546.id49009.diff
Mar 5 2025, 6:54 PM
Subscribers
None

Details

Summary

Ref T13283. Currently, each Editor sets its own group ID, so if you create a revision and then Herald does some stuff, the two groups of transactions get different group IDs.

This means the test console is slightly misleading (it will only pick up the Herald transactions). It's going to be misleading anyway (Herald obviously can't evaluate Herald transactions) but this is at least a little closer to reality and stops Herald actions from masking non-Herald actions.

Test Plan
  • Created a revision. Herald applied one transaction.
  • Used the test console.
  • Before: The test console only picked up the single most recent Herald transaction.
  • After: The test console picked up the whole transaction group.

Screen Shot 2019-05-22 at 2.38.14 PM.png (377×1 px, 77 KB)

Diff Detail

Repository
rP Phabricator
Branch
xgroup1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22885
Build 31394: Run Core Tests
Build 31393: arc lint + arc unit