Page MenuHomePhabricator

Prevent "Differential Revision: ..." from counting as a mention in commit messages
ClosedPublic

Authored by epriestley on May 22 2019, 9:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 29, 6:37 PM
Unknown Object (File)
Mon, Dec 23, 8:23 PM
Unknown Object (File)
Sat, Dec 14, 10:43 PM
Unknown Object (File)
Sat, Dec 14, 11:16 AM
Unknown Object (File)
Fri, Dec 13, 3:25 AM
Unknown Object (File)
Tue, Dec 10, 8:07 PM
Unknown Object (File)
Tue, Dec 10, 8:07 PM
Unknown Object (File)
Tue, Dec 10, 7:57 PM
Subscribers
None

Details

Summary

Ref T13290. Ref T13291. Now that a full URI is a "mention", the full URI in "Differential Revision: ..." also triggers a mention.

Stop it from doing that, since these mentions are silly/redundant/unintended.

The API here is also slightly odd; simplify it a little bit to get rid of doing "append" with "get + append + set".

Test Plan

Used bin/repository reparse --publish to republish commits with "Differential Revision: ..." and verified that the revision PHID was properly dropped from the mention list.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable