Page MenuHomePhabricator

Be more strict when checking linter versions
Needs ReviewPublic

Authored by joshuaspence on May 22 2019, 1:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 16, 6:19 PM
Unknown Object (File)
Tue, Apr 16, 6:19 PM
Unknown Object (File)
Thu, Apr 11, 4:22 AM
Unknown Object (File)
Thu, Mar 21, 6:56 AM
Unknown Object (File)
Mar 16 2024, 11:14 AM
Unknown Object (File)
Mar 1 2024, 5:27 AM
Unknown Object (File)
Feb 21 2024, 1:47 PM
Unknown Object (File)
Feb 21 2024, 4:06 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Curently ArcanistExternalLinterTestCase::testVersion passes so long as the linter being tested returns anything other than the literal false. Make this more strict by asserting that the return value must have a non-zero length.

Test Plan

Ran unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
lint4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22864
Build 31369: Run Core Tests
Build 31368: arc lint + arc unit