Page MenuHomePhabricator

Be more strict when checking linter versions
Needs ReviewPublic

Authored by joshuaspence on May 22 2019, 1:25 AM.
Tags
None
Referenced Files
F13086836: D20542.diff
Thu, Apr 25, 12:44 AM
F13086826: D20542.diff
Thu, Apr 25, 12:44 AM
Unknown Object (File)
Mon, Apr 22, 9:23 AM
Unknown Object (File)
Fri, Apr 19, 8:24 PM
Unknown Object (File)
Fri, Apr 19, 3:14 AM
Unknown Object (File)
Fri, Apr 19, 3:14 AM
Unknown Object (File)
Fri, Apr 19, 3:14 AM
Unknown Object (File)
Tue, Apr 16, 6:19 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Curently ArcanistExternalLinterTestCase::testVersion passes so long as the linter being tested returns anything other than the literal false. Make this more strict by asserting that the return value must have a non-zero length.

Test Plan

Ran unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
lint4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22863
Build 31367: Run Core Tests
Build 31366: arc lint + arc unit