Page MenuHomePhabricator

Be more strict when checking linter versions
Needs ReviewPublic

Authored by joshuaspence on May 22 2019, 1:25 AM.
Tags
None
Referenced Files
F22712461: D20542.id48988.diff
Sat, Oct 3, 2:30 PM
F22712458: D20542.id48988.diff
Sat, Oct 3, 2:25 PM
F22712453: D20542.id48988.diff
Sat, Oct 3, 2:15 PM
F22616691: D20542.id48987.diff
Tue, Sep 29, 10:56 AM
Unknown Object (File)
Sat, Sep 12, 3:09 AM
Unknown Object (File)
Aug 31 2026, 1:32 AM
Unknown Object (File)
Aug 23 2026, 3:45 AM
Unknown Object (File)
Jul 3 2026, 11:10 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Curently ArcanistExternalLinterTestCase::testVersion passes so long as the linter being tested returns anything other than the literal false. Make this more strict by asserting that the return value must have a non-zero length.

Test Plan

Ran unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
lint4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22863
Build 31367: Run Core Tests
Build 31366: arc lint + arc unit