Differential D20388

Fix two minor main menu bar CSS issues
ClosedPublic
Actions

Authored by epriestley on Apr 10 2019, 5:01 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 11, 8:43 AM

	Unknown Object (File)
	Thu, Apr 4, 1:21 PM

	Unknown Object (File)
	Thu, Apr 4, 4:55 AM

	Unknown Object (File)
	Mon, Apr 1, 7:55 PM

	Unknown Object (File)
	Mon, Apr 1, 7:55 PM

	Unknown Object (File)
	Mon, Apr 1, 7:55 PM

	Unknown Object (File)
	Mon, Apr 1, 7:55 PM

	Unknown Object (File)
	Mar 16 2024, 11:03 AM

View All 91 Files

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13263: Plans: 2019 Week 11-15 Bonus Content

Commits

rP299b6f420d58: Fix two minor main menu bar CSS issues

Summary

Make the user profile section of the "Profile" dropdown menu have a transparent background, not a white background. This is a pre-existing issue. This is normally hard to see, but visible on Workboards with custom background colors.
Fix an alignment issue with the little "V" caret in the search scope dropdown. This is a recent issue caused by some tab-caret CSS I added recently for tabbed dashboard panels.

Test Plan

Before:

Screen Shot 2019-04-10 at 9.59.44 AM.png (173×402 px, 14 KB)

After:

Screen Shot 2019-04-10 at 9.59.06 AM.png (204×398 px, 16 KB)

Diff Detail

Repository

Branch

css1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22526
Build 30843: Run Core Tests
Build 30842: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 10 2019, 5:01 PM

Harbormaster completed remote builds in B22526: Diff 48651.Apr 10 2019, 5:03 PM

epriestley requested review of this revision.Apr 10 2019, 5:03 PM

amckinley accepted this revision.Apr 10 2019, 5:44 PM

This revision is now accepted and ready to land.Apr 10 2019, 5:44 PM

Closed by commit rP299b6f420d58: Fix two minor main menu bar CSS issues (authored by epriestley). · Explain WhyApr 10 2019, 6:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

webroot/

rsrc/

css/

application/

base/

main-menu-view.css

1 line

phui/

phui-action-list.css

4 lines

Diff 48651

resources/celerity/map.php

Loading...

webroot/rsrc/css/application/base/main-menu-view.css

Loading...

webroot/rsrc/css/phui/phui-action-list.css

Loading...