Page MenuHomePhabricator
Differential D20366

Fix rendering of offset-paged query panels including "Notifications"
ClosedPublic
Actions

Authored by epriestley on Apr 2 2019, 12:45 PM.
Tags
None
Referenced Files
F18944965: D20366.id48591.diff
Nov 11 2025, 5:24 PM
F18901161: D20366.id48618.diff
Nov 7 2025, 9:40 PM
F18900012: D20366.id.diff
Nov 7 2025, 8:26 PM
F18839631: D20366.diff
Oct 27 2025, 5:47 PM
F18783284: D20366.id48618.diff
Oct 13 2025, 5:45 AM
F18764464: D20366.id48591.diff
Oct 7 2025, 6:13 AM
F18762126: D20366.diff
Oct 6 2025, 5:40 PM
F18757572: D20366.id.diff
Oct 5 2025, 6:13 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rP51d9453e5341: (stable) Fix rendering of offset-paged query panels including "Notifications"
rPe45ccdd89249: Fix rendering of offset-paged query panels including "Notifications"
Summary

See https://discourse.phabricator-community.org/t/call-to-undefined-method-phuipagerview-gethasmoreresults-in-2019-week-13/2586/.

A small number of queries (including "Notifications" and (global) "Search") use offset-based pagers which have a slightly different API PHUIPagerView instead of AphrontCursorPagerView. This leads to a fatal in the new code for the "View All Results" buttons.

To fix this, just do an instanceof test. Some day we can unify the pagers.

Test Plan

Added a notifications panel, rendered it, saw it work instead of fataling on "getHasMoreResults()". Also rendered some normal panels.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
dashboard/
paneltype/
11 lines

Diff 48618

View Options

src/applications/dashboard/paneltype/PhabricatorDashboardQueryPanelType.php

Loading...
Phabricator · Built by Phacility