Paths

Table of Contentst

Differential D20366

Fix rendering of offset-paged query panels including "Notifications"
ClosedPublic
Actions

Authored by epriestley on Apr 2 2019, 12:45 PM.

Tags

None

Referenced Files

	F15533627: D20366.diff
	Wed, Apr 23, 8:49 PM

	F15515925: D20366.diff
	Fri, Apr 18, 2:37 PM

	F15498653: D20366.id48591.diff
	Sun, Apr 13, 1:42 PM

	F15490781: D20366.id48618.diff
	Fri, Apr 11, 8:33 PM

	F15488165: D20366.id.diff
	Thu, Apr 10, 8:05 PM

	F15484213: D20366.diff
	Wed, Apr 9, 5:09 PM

	F15380773: D20366.diff
	Mar 14 2025, 4:26 AM

	Unknown Object (File)
	Feb 24 2025, 2:34 AM

Subscribers

None

Details

Reviewers

Commits

rP51d9453e5341: (stable) Fix rendering of offset-paged query panels including "Notifications"
rPe45ccdd89249: Fix rendering of offset-paged query panels including "Notifications"

Summary

See https://discourse.phabricator-community.org/t/call-to-undefined-method-phuipagerview-gethasmoreresults-in-2019-week-13/2586/.

A small number of queries (including "Notifications" and (global) "Search") use offset-based pagers which have a slightly different API PHUIPagerView instead of AphrontCursorPagerView. This leads to a fatal in the new code for the "View All Results" buttons.

To fix this, just do an instanceof test. Some day we can unify the pagers.

Test Plan

Added a notifications panel, rendered it, saw it work instead of fataling on "getHasMoreResults()". Also rendered some normal panels.

Diff Detail

Repository

Branch

page1

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/dashboard/paneltype/PhabricatorDashboardQueryPanelType.php:139	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 22465
Build 30753: Run Core Tests
Build 30752: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 2 2019, 12:45 PM

Harbormaster completed remote builds in B22465: Diff 48591.Apr 2 2019, 12:47 PM

epriestley requested review of this revision.Apr 2 2019, 12:47 PM

amckinley accepted this revision.Apr 3 2019, 6:43 PM

This revision is now accepted and ready to land.Apr 3 2019, 6:43 PM

Closed by commit rPe45ccdd89249: Fix rendering of offset-paged query panels including "Notifications" (authored by epriestley). · Explain WhyApr 4 2019, 1:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

paneltype/

PhabricatorDashboardQueryPanelType.php

11 lines

Diff 48591

src/applications/dashboard/paneltype/PhabricatorDashboardQueryPanelType.php

Loading...