Differential D20346

When drawing a very wide graph line diagram, smush it together a bit
ClosedPublic
Actions

Authored by epriestley on Mar 29 2019, 12:57 AM.

Tags

None

Referenced Files

	F14849380: D20346.diff
	Tue, Feb 4, 1:51 AM

	Unknown Object (File)
	Sat, Jan 25, 4:29 AM

	Unknown Object (File)
	Sat, Jan 25, 4:29 AM

	Unknown Object (File)
	Sat, Jan 25, 4:28 AM

	Unknown Object (File)
	Sat, Jan 25, 1:29 AM

	Unknown Object (File)
	Mon, Jan 13, 5:05 PM

	Unknown Object (File)
	Jan 2 2025, 11:40 PM

	Unknown Object (File)
	Dec 25 2024, 5:34 PM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rPcec779cdabee: When drawing a very wide graph line diagram, smush it together a bit

Summary

Depends on D20345. Use a narrower layout for very large graphs to save some space.

Test Plan

Before:

Screen Shot 2019-03-28 at 5.49.14 PM.png (1×1 px, 324 KB)

After:

Screen Shot 2019-03-28 at 5.49.22 PM.png (1×1 px, 320 KB)

This does not affect smaller graphs.

Diff Detail

Repository

rP Phabricator

Branch

graph2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22429
Build 30693: Run Core Tests
Build 30692: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 29 2019, 12:57 AM

Harbormaster completed remote builds in B22429: Diff 48558.Mar 29 2019, 12:58 AM

epriestley requested review of this revision.Mar 29 2019, 12:58 AM

amckinley accepted this revision.Mar 29 2019, 3:23 AM

This revision is now accepted and ready to land.Mar 29 2019, 3:23 AM

Closed by commit rPcec779cdabee: When drawing a very wide graph line diagram, smush it together a bit (authored by epriestley). · Explain WhyMar 29 2019, 4:19 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

js/

application/

diffusion/

behavior-commit-graph.js

10 lines

Diff 48558

View Options

resources/celerity/map.php