Page MenuHomePhabricator

Improve overflow/ellipsis behaivor for very wide task graphs
ClosedPublic

Authored by epriestley on Mar 29 2019, 12:45 AM.
Tags
None
Referenced Files
F15516656: D20345.id48560.diff
Fri, Apr 18, 8:20 PM
F15492044: D20345.id48557.diff
Sat, Apr 12, 10:09 AM
F15489816: D20345.id48557.diff
Fri, Apr 11, 12:32 PM
F15482391: D20345.id48556.diff
Wed, Apr 9, 5:10 AM
F15478999: D20345.id48560.diff
Tue, Apr 8, 4:41 AM
F15478886: D20345.id48557.diff
Tue, Apr 8, 3:38 AM
F15478164: D20345.id.diff
Mon, Apr 7, 8:53 PM
F15475556: D20345.diff
Sun, Apr 6, 8:30 PM
Subscribers
None
Tokens
"Love" token, awarded by leoluk.

Details

Summary

See downstream https://phabricator.wikimedia.org/T171648. The T123 Task Name column in graphs can currently fold down to 0 pixels wide.

Although it's visually nice to render this element without a scroll bar when we don't really need one, the current behavior is excessive and not very useful.

Instead, tweak the CSS so:

  • This cell is always at least 320px wide.
  • After 320px, we'll overflow/ellipsis the cell on small screens.

This generally gives us better behavior:

  • Small screens get a scrollbar to see a reasonable amount of content.
  • The UI doesn't turn into a total mess if one task has a whole novel of text.
Test Plan

Old behavior, note that there's no scrollbar and the cell is so narrow it is useless:

Screen Shot 2019-03-28 at 5.39.37 PM.png (1×669 px, 237 KB)

New behavior, same default view, has a scrollbar:

Screen Shot 2019-03-28 at 5.39.54 PM.png (1×669 px, 247 KB)

Scrolling over gives you this:

Screen Shot 2019-03-28 at 5.39.56 PM.png (1×669 px, 253 KB)

On a wider screen (this wide or better), we don't need to scroll:

Screen Shot 2019-03-28 at 5.40.11 PM.png (1×953 px, 305 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable