Page MenuHomePhabricator

Improve overflow/ellipsis behaivor for very wide task graphs
ClosedPublic

Authored by epriestley on Mar 29 2019, 12:45 AM.

Details

Summary

See downstream https://phabricator.wikimedia.org/T171648. The T123 Task Name column in graphs can currently fold down to 0 pixels wide.

Although it's visually nice to render this element without a scroll bar when we don't really need one, the current behavior is excessive and not very useful.

Instead, tweak the CSS so:

  • This cell is always at least 320px wide.
  • After 320px, we'll overflow/ellipsis the cell on small screens.

This generally gives us better behavior:

  • Small screens get a scrollbar to see a reasonable amount of content.
  • The UI doesn't turn into a total mess if one task has a whole novel of text.
Test Plan

Old behavior, note that there's no scrollbar and the cell is so narrow it is useless:

New behavior, same default view, has a scrollbar:

Scrolling over gives you this:

On a wider screen (this wide or better), we don't need to scroll:

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 29 2019, 12:45 AM
Harbormaster returned this revision to the author for changes because remote builds failed.
  • Update Celerity map.
epriestley requested review of this revision.Mar 29 2019, 12:56 AM
amckinley accepted this revision.Mar 29 2019, 3:25 AM
This revision is now accepted and ready to land.Mar 29 2019, 3:25 AM
This revision was automatically updated to reflect the committed changes.