Page MenuHomePhabricator

Fix content overflow in user hovercards
ClosedPublic

Authored by epriestley on Mar 29 2019, 12:21 AM.
Tags
None
Referenced Files
F14112912: D20344.diff
Thu, Nov 28, 3:08 AM
Unknown Object (File)
Tue, Nov 26, 6:27 AM
Unknown Object (File)
Tue, Nov 26, 6:27 AM
Unknown Object (File)
Tue, Nov 26, 6:27 AM
Unknown Object (File)
Sun, Nov 24, 7:57 AM
Unknown Object (File)
Thu, Nov 21, 11:57 AM
Unknown Object (File)
Wed, Nov 20, 7:49 PM
Unknown Object (File)
Mon, Nov 11, 4:54 AM
Subscribers
None

Details

Summary

Fixes T13273. This element is a bit weird, but I think I fixed it without breaking anything.

The CSS is used by project hovercards and user hovercards, but they each have a class which builds mostly-shared-but-not-really-identical CSS, instead of having a single View class with modes. So I'm not 100% sure I didn't break something obscure, but I couldn't find anything this breaks.

The major issue is that all the text content has "position: absolute". Instead, make the image "absolute" and the text actual positioned content. Then fix all the margins/padding/spacing/layout and add overflow. Seems to work?

Plus: hide availability for disabled users, for consistency with D20342.

Test Plan

Before:

Screen Shot 2019-03-28 at 5.13.25 PM.png (373×1 px, 74 KB)

After:

Screen Shot 2019-03-28 at 5.13.19 PM.png (315×479 px, 38 KB)

I think this is pixel-exact except for the overflow behavior.

Also:

  • Viewed some other user hovercards, including a disabled user. They all looked unchanged.
  • Viewed some project hovercards. They all looked good, too.

Diff Detail

Repository
rP Phabricator
Branch
hover1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22422
Build 30682: Run Core Tests
Build 30681: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Mar 29 2019, 3:24 AM
This revision was automatically updated to reflect the committed changes.