Page MenuHomePhabricator

Hide "Availability" and "Calendar" on user profiles for disabled users
ClosedPublic

Authored by epriestley on Thu, Mar 28, 11:26 PM.

Details

Summary

See downstream https://phabricator.wikimedia.org/T138723. That suggestion is a little light on details, but I basically agree that showing "Availability: Available" on disabled user profiles is kind of questionable/misleading.

Just hide event information on disabled profiles, since this doesn't seem worth building a special "Availability: Who Knows, They Are Disabled, Good Luck" disabled state for.

Test Plan

Looked at disabled and non-disabled user profiles, saw Calendar stuff only on the former.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Mar 28, 11:26 PM
epriestley requested review of this revision.Thu, Mar 28, 11:27 PM
amckinley accepted this revision.Thu, Mar 28, 11:31 PM

While you're here, have you taken a look at T13273?

This revision is now accepted and ready to land.Thu, Mar 28, 11:31 PM
This revision was automatically updated to reflect the committed changes.