Add a "Play Sound" workboard trigger rule
ClosedPublic
Actions

Authored by epriestley on Mar 21 2019, 10:26 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T5474: Support workboard column triggers which activate when a task is dropped into a column

Commits

rPbfa5ffe8a1ea: Add a "Play Sound" workboard trigger rule

Summary

Ref T5474. Allow columns to play a sound when tasks are dropped.

This is a little tricky because Safari has changed somewhat recently to require some gymnastics to play sounds when the user didn't explicitly click something. Preloading the sound on the first mouse interaction, then playing and immediately pausing it seems to work, though.

Test Plan

Added a trigger with 5 sounds. In Safari, Chrome, and Firefox, dropped a card into the column. In all browsers, heard a nice sequence of 5 sounds played one after the other.

Diff Detail

Repository

rP Phabricator

Branch

trigger12

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22360
Build 30593: Run Core Tests
Build 30592: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 21 2019, 10:26 PM

Harbormaster completed remote builds in B22324: Diff 48460.Mar 21 2019, 10:28 PM

epriestley requested review of this revision.Mar 21 2019, 10:28 PM

amckinley accepted this revision.Mar 25 2019, 6:31 PM

amckinley added inline comments.

webroot/rsrc/js/application/projects/behavior-project-boards.js
172	This callback only gets triggered on the first `mousedown`, right?

This revision is now accepted and ready to land.Mar 25 2019, 6:31 PM

epriestley added inline comments.Mar 25 2019, 6:36 PM

webroot/rsrc/js/application/projects/behavior-project-boards.js
172	It runs on each click, but `sounds` is empty after the first time so it's effectively a no-op. (There's currently no super convenient way to do a `listenOnce()` kind of thing. The callback could unregister the listener, but the cost of keeping this callback around should be insignificant.)