Differential D20264

Remove opacity effects for left-side / right-side diff text selection
ClosedPublic
Actions

Authored by epriestley on Mar 7 2019, 10:06 PM.

Details

Reviewers

Commits

rP7574be5372fe: Remove opacity effects for left-side / right-side diff text selection

Summary

These effects feel like they're possibly overkill, since other CSS rules make the selection reticle behave correctly and the implementation is relatively intuitive.

Or not, either way.

Test Plan

Selected text on either side of a 2-up diff, no more opacity effects.

Diff Detail

Repository

rP Phabricator

Branch

copy1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22229
Build 30393: Run Core Tests
Build 30392: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 7 2019, 10:06 PM

Harbormaster completed remote builds in B22229: Diff 48370.Mar 7 2019, 10:07 PM

epriestley requested review of this revision.Mar 7 2019, 10:07 PM

I think I lean toward "yeah, let's get rid of this" after sleeping on it.

In D20264#254338, @epriestley wrote:

I think I lean toward "yeah, let's get rid of this" after sleeping on it.

Ditto.

This revision is now accepted and ready to land.Mar 12 2019, 6:38 PM

Closed by commit rP7574be5372fe: Remove opacity effects for left-side / right-side diff text selection (authored by epriestley). · Explain WhyMar 12 2019, 7:40 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

css/

application/

differential/

changeset-view.css

5 lines

Diff 48370

View Options

resources/celerity/map.php