Page MenuHomePhabricator

Make minor correctness changes to some "arc patch" command execution
ClosedPublic

Authored by epriestley on Mar 6 2019, 6:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Aug 11 2026, 7:12 AM
Unknown Object (File)
Jul 3 2026, 3:40 AM
Unknown Object (File)
Mar 29 2026, 5:33 AM
Unknown Object (File)
Mar 28 2026, 1:29 PM
Unknown Object (File)
Mar 27 2026, 6:26 PM
Unknown Object (File)
Mar 25 2026, 5:55 AM
Unknown Object (File)
Mar 19 2026, 2:20 AM
Unknown Object (File)
Mar 19 2026, 2:00 AM
Subscribers
None

Details

Summary

Since I'm in here for PHI1083:

  • Add some "--" so we get correct behavior when you have a file named "master", a branch named "README.txt", etc.
  • Stop using "%C" unnecessarily.
  • Fix some untranslatable strings.
Test Plan

Ran arc patch a couple of times, ran the variations of git commands to catch anything weird with "--" handling.

Diff Detail

Repository
rARC Arcanist
Branch
patch2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22205
Build 30355: Run Core Tests
Build 30354: arc lint + arc unit