Page MenuHomePhabricator

Implement Build Plan "Hold Drafts" behavior
ClosedPublic

Authored by epriestley on Feb 28 2019, 9:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 17, 1:38 AM
Unknown Object (File)
Fri, Mar 1, 7:30 PM
Unknown Object (File)
Jan 10 2024, 11:16 PM
Unknown Object (File)
Jan 2 2024, 1:28 PM
Unknown Object (File)
Dec 28 2023, 7:48 PM
Unknown Object (File)
Dec 24 2023, 4:42 PM
Unknown Object (File)
Dec 21 2023, 2:50 AM
Unknown Object (File)
Dec 3 2023, 3:03 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13258. Makes the new "Hold Drafts" behavior actually work.

Test Plan
  • Created a build plan which does "Make HTTP Request" somewhere random and then waits for a message.
  • Created a Herald rule which "Always" runs this plan.
  • Created revisions, loaded them, then sent their build targets a "fail" message a short time later.
    • With "Always": Current behavior. Revision was held as a draft while building, and returned to me for changes when the build failed.
    • With "If Building": Revision was held as a draft while building, but promoted once the build failed.
    • With "Never": Revision promoted immediately, ignoring the build completely.

Diff Detail

Repository
rP Phabricator
Branch
harbor9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22154
Build 30277: Run Core Tests
Build 30276: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 28 2019, 9:12 PM
This revision is now accepted and ready to land.Mar 5 2019, 7:49 PM
This revision was automatically updated to reflect the committed changes.