Ref T13258. Makes the new "Hold Drafts" behavior actually work.
Details
Details
- Created a build plan which does "Make HTTP Request" somewhere random and then waits for a message.
- Created a Herald rule which "Always" runs this plan.
- Created revisions, loaded them, then sent their build targets a "fail" message a short time later.
- With "Always": Current behavior. Revision was held as a draft while building, and returned to me for changes when the build failed.
- With "If Building": Revision was held as a draft while building, but promoted once the build failed.
- With "Never": Revision promoted immediately, ignoring the build completely.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- harbor9
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 22154 Build 30277: Run Core Tests Build 30276: arc lint + arc unit