Page MenuHomePhabricator

Use "QUERY_STRING", not "REQUEST_URI", to parse raw request parameters
ClosedPublic

Authored by epriestley on Feb 28 2019, 6:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 1:32 AM
Unknown Object (File)
Wed, Apr 17, 2:54 PM
Unknown Object (File)
Tue, Apr 16, 4:45 PM
Unknown Object (File)
Mon, Apr 15, 10:38 PM
Unknown Object (File)
Thu, Apr 11, 7:08 AM
Unknown Object (File)
Thu, Apr 11, 7:08 AM
Unknown Object (File)
Wed, Apr 10, 7:53 PM
Unknown Object (File)
Wed, Apr 3, 12:03 PM
Subscribers
None

Details

Summary

Fixes T13260. "QUERY_STRING" and "REQUEST_URI" are similar for our purposes here, but our nginx documentation tells you to pass "QUERY_STRING" and doesn't tell you to pass "REQUEST_URI". We also use "QUERY_STRING" in a couple of other places already, and already have a setup check for it.

Use "QUERY_STRING" instead of "REQUEST_URI".

Test Plan

Visited /oauth/google/?a=b, got redirected with parameters preserved.

Diff Detail

Repository
rP Phabricator
Branch
query1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22149
Build 30267: Run Core Tests
Build 30266: arc lint + arc unit