Page MenuHomePhabricator

Use "QUERY_STRING", not "REQUEST_URI", to parse raw request parameters
ClosedPublic

Authored by epriestley on Feb 28 2019, 6:42 PM.
Tags
None
Referenced Files
F12839550: D20227.diff
Thu, Mar 28, 7:35 PM
Unknown Object (File)
Sun, Mar 17, 11:06 PM
Unknown Object (File)
Wed, Mar 13, 7:41 AM
Unknown Object (File)
Tue, Mar 5, 8:33 AM
Unknown Object (File)
Jan 19 2024, 7:46 AM
Unknown Object (File)
Dec 19 2023, 10:34 PM
Unknown Object (File)
Dec 15 2023, 10:29 AM
Unknown Object (File)
Dec 6 2023, 7:51 AM
Subscribers
None

Details

Summary

Fixes T13260. "QUERY_STRING" and "REQUEST_URI" are similar for our purposes here, but our nginx documentation tells you to pass "QUERY_STRING" and doesn't tell you to pass "REQUEST_URI". We also use "QUERY_STRING" in a couple of other places already, and already have a setup check for it.

Use "QUERY_STRING" instead of "REQUEST_URI".

Test Plan

Visited /oauth/google/?a=b, got redirected with parameters preserved.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable