Page MenuHomePhabricator

Stop "Mute Notifications" on Bulk Jobs from fataling
ClosedPublic

Authored by epriestley on Feb 28 2019, 5:48 PM.
Tags
None
Referenced Files
F12808078: D20226.id48286.diff
Wed, Mar 27, 8:18 PM
Unknown Object (File)
Thu, Mar 21, 9:06 AM
Unknown Object (File)
Wed, Mar 20, 9:18 PM
Unknown Object (File)
Fri, Mar 15, 2:26 PM
Unknown Object (File)
Sun, Mar 10, 8:51 AM
Unknown Object (File)
Mon, Mar 4, 3:33 PM
Unknown Object (File)
Feb 24 2024, 8:05 PM
Unknown Object (File)
Feb 19 2024, 9:39 AM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/unhandled-exception-muting-completed-bulk-jobs/2449. Bulk Jobs have an "edge" table but currently do not support edge transactions. Add support.

This stops "Mute Notifications" from fataling.

The action probably doesn't do what the reporting user expects (it stops edits to the job object from sending notifications; it does not stop the edits the job performs from sending notifications) but I think this change puts us in a better place no matter what, even if we eventually clarify or remove this behavior.

Test Plan

Clicked "Mute Notifications" on a bulk job, got an effect instead of a fatal.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable