Page MenuHomePhabricator

Stop "Mute Notifications" on Bulk Jobs from fataling
ClosedPublic

Authored by epriestley on Feb 28 2019, 5:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 2:46 AM
Unknown Object (File)
Sun, Apr 21, 1:06 PM
Unknown Object (File)
Wed, Apr 17, 9:25 PM
Unknown Object (File)
Mon, Apr 15, 11:54 AM
Unknown Object (File)
Mon, Apr 8, 1:09 AM
Unknown Object (File)
Wed, Apr 3, 12:03 PM
Unknown Object (File)
Wed, Apr 3, 7:25 AM
Unknown Object (File)
Sat, Mar 30, 7:20 AM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/unhandled-exception-muting-completed-bulk-jobs/2449. Bulk Jobs have an "edge" table but currently do not support edge transactions. Add support.

This stops "Mute Notifications" from fataling.

The action probably doesn't do what the reporting user expects (it stops edits to the job object from sending notifications; it does not stop the edits the job performs from sending notifications) but I think this change puts us in a better place no matter what, even if we eventually clarify or remove this behavior.

Test Plan

Clicked "Mute Notifications" on a bulk job, got an effect instead of a fatal.

Diff Detail

Repository
rP Phabricator
Branch
mute1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22148
Build 30265: Run Core Tests
Build 30264: arc lint + arc unit