Page MenuHomePhabricator

Enrich the "change project tags" transaction in "transaction.search"
ClosedPublic

Authored by epriestley on Feb 25 2019, 1:35 PM.
Tags
None
Referenced Files
F13055255: D20209.id.diff
Fri, Apr 19, 12:33 PM
F13050591: D20209.id48256.diff
Fri, Apr 19, 3:02 AM
F13050589: D20209.id48250.diff
Fri, Apr 19, 3:02 AM
F13050587: D20209.id.diff
Fri, Apr 19, 3:02 AM
Unknown Object (File)
Tue, Apr 16, 9:14 AM
Unknown Object (File)
Thu, Apr 11, 4:13 AM
Unknown Object (File)
Mon, Apr 1, 1:29 PM
Unknown Object (File)
Mon, Apr 1, 3:38 AM
Subscribers
None
Tokens
"Love" token, awarded by aklapper.

Details

Summary

Depends on D20208. Ref T13255. See that task for some long-winded discussion and rationale. Short version:

  • This is a list of operations instead of a list of old/new PHIDs because of scalability issues for large lists (T13056).
  • This is a fairly verbose list (instead of, for example, the more concise internal map we sometimes use with "+" and "-" as keys) to try to make the structure obvious and extensible in the future.
  • The "add" and "remove" echo the *.edit operations.
Test Plan

Called transaction.search on an object with project tag changes, saw them in the results.

Diff Detail

Repository
rP Phabricator
Branch
xaction2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22111
Build 30207: Run Core Tests
Build 30206: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Feb 25 2019, 3:16 PM

I guess there's some argument I should call this "tags" instead of "projects", but the *.edit transactions are called "projects", and I think most of the projects/tags confusion we hit historically was around new users figuring things out, not users digging into the API.

This revision was automatically updated to reflect the committed changes.