Page MenuHomePhabricator

Queue search indexing tasks at a new PRIORITY_INDEX, not PRIORITY_IMPORT
ClosedPublic

Authored by epriestley on Feb 15 2019, 1:09 PM.

Details

Summary

Depends on D20175. Ref T12425. Ref T13253. Currently, importing commits can stall search index rebuilds, since index rebuilds use an older priority from before T11677 and weren't really updated for D16585.

In general, we'd like to complete all indexing tasks before continuing repository imports. A possible exception is if you rebuild an entire index with bin/search index --rebuild-the-world, but we could queue those at a separate lower priority if issues arise.

Test Plan

Ran some search indexing through the queue.

Diff Detail

Repository
rP Phabricator
Branch
daemon2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22017
Build 30076: Run Core Tests
Build 30075: arc lint + arc unit