Page MenuHomePhabricator

When users follow an email login link but an install does not use passwords, try to get them to link an account
ClosedPublic

Authored by epriestley on Feb 14 2019, 3:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 5, 1:31 AM
Unknown Object (File)
Feb 13 2024, 10:18 PM
Unknown Object (File)
Feb 9 2024, 7:17 AM
Unknown Object (File)
Dec 15 2023, 2:31 PM
Unknown Object (File)
Nov 30 2023, 3:52 AM
Unknown Object (File)
Nov 16 2023, 7:56 PM
Unknown Object (File)
Oct 30 2023, 1:59 PM
Unknown Object (File)
Sep 10 2023, 3:26 AM
Subscribers
None

Details

Summary

Ref T13249. See PHI774. When users follow an email login link ("Forgot password?", "Send Welcome Email", "Send a login link to your email address.", bin/auth recover), we send them to a password reset flow if an install uses passwords.

If an install does not use passwords, we previously dumped them unceremoniously into the SettingsExternal Accounts UI with no real guidance about what they were supposed to do. Since D20094 we do a slightly better job here in some cases. Continue improving this workflow.

This adds a page like "Reset Password" for "Hey, You Should Probably Link An Account, Here's Some Options".

Overall, this stuff is still pretty rough in a couple of areas that I imagine addressing in the future:

  • When you finish linking, we still dump you back in Settings. At least we got you to link things. But better would be to return you here and say "great job, you're a pro".
  • This UI can become a weird pile of buttons in certain configs and generally looks a little unintentional. This problem is shared among all the "linkable" providers, and the non-login link flow is also weird.

So: step forward, but more work to be done.

Test Plan

Screen Shot 2019-02-14 at 6.59.18 AM.png (732×1 px, 150 KB)

Diff Detail

Repository
rP Phabricator
Branch
welcome1x
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21999
Build 30050: Run Core Tests
Build 30049: arc lint + arc unit