Page MenuHomePhabricator

When users follow an email login link but an install does not use passwords, try to get them to link an account
ClosedPublic

Authored by epriestley on Feb 14 2019, 3:11 PM.

Details

Summary

Ref T13249. See PHI774. When users follow an email login link ("Forgot password?", "Send Welcome Email", "Send a login link to your email address.", bin/auth recover), we send them to a password reset flow if an install uses passwords.

If an install does not use passwords, we previously dumped them unceremoniously into the SettingsExternal Accounts UI with no real guidance about what they were supposed to do. Since D20094 we do a slightly better job here in some cases. Continue improving this workflow.

This adds a page like "Reset Password" for "Hey, You Should Probably Link An Account, Here's Some Options".

Overall, this stuff is still pretty rough in a couple of areas that I imagine addressing in the future:

  • When you finish linking, we still dump you back in Settings. At least we got you to link things. But better would be to return you here and say "great job, you're a pro".
  • This UI can become a weird pile of buttons in certain configs and generally looks a little unintentional. This problem is shared among all the "linkable" providers, and the non-login link flow is also weird.

So: step forward, but more work to be done.

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 14 2019, 3:11 PM
epriestley requested review of this revision.Feb 14 2019, 3:13 PM
amckinley accepted this revision.Feb 15 2019, 10:04 PM
This revision is now accepted and ready to land.Feb 15 2019, 10:04 PM
This revision was automatically updated to reflect the committed changes.