Page MenuHomePhabricator

Rate limit attempts to add payment methods in Phortune
ClosedPublic

Authored by epriestley on Feb 13 2019, 1:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 25 2024, 8:54 AM
Unknown Object (File)
Oct 23 2024, 9:36 PM
Unknown Object (File)
Oct 21 2024, 11:39 AM
Unknown Object (File)
Oct 17 2024, 9:21 PM
Unknown Object (File)
Oct 15 2024, 3:45 AM
Unknown Object (File)
Oct 13 2024, 10:19 PM
Unknown Object (File)
Oct 9 2024, 11:40 AM
Unknown Object (File)
Oct 2 2024, 8:40 AM
Subscribers
None

Details

Summary

Ref T13249. See D20132. Although we're probably a poor way to validate a big list of stolen cards in practice in production today (it's very hard to quickly generate a large number of small charges), putting rate limiting on "Add Payment Method" is generally reasonable, can't really hurt anything (no legitimate user will ever hit this limit), and might frustrate attackers in the future if it becomes easier to generate ad-hoc charges (for example, if we run a deal on support pacts and reduce their cost from $1,000 to $1).

Test Plan

Reduced limit to 4 / hour, tried to add a card several times, got rate limited.

Diff Detail

Repository
rP Phabricator
Branch
payment1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21979
Build 30018: Run Core Tests
Build 30017: arc lint + arc unit